C 鏈表佇列指標導致未定義的行為

我已經閱讀了這些問題，但沒有看到我的答案。大多數人對這些使用結構，在測驗參考代碼之后，我看到結構版本是功能性的，但是，為什么類版本不是？

#include <iostream>
using namespace std;

// I'm still bad at pointer logic but it makes sense.
// REFERENCES
// https://www.geeksforgeeks.org/queue-linked-list-implementation/
// stack linked list assignment earlier in semester
// https://stackoverflow.com/questions/29787026/c-queue-from-linked-list
class Node {
    public:
    int data;
    Node *next;         // controls flow of nodes
};

class Queue {
    public:
    Queue();
    ~Queue();
    void enQueue(int data);
    void deQueue();
    bool isEmpty();
    
    //private: all set to public because I don't want to make a print function
    Node *front;
    Node *rear;
    int counter;
};

Queue::Queue()

{
    
    front = NULL;
    rear  = NULL;
    
}

Queue::~Queue() {
    
    if (rear == NULL && front == NULL)
    {
        cout << "Nothing to clean up!" << endl;
    }
    else
    {
        cout << "Delete should be happening now...";
    }
}

void Queue::enQueue(int data) {

    // create new node of queue structure
    Node *temp  = new Node;
    temp->data  = data;
    
    // write like this line below if not temp->data = data;
    // Node *temp = new Node(data); 
    
    // if the queue is empty, first node.
    if (rear == NULL)
    {
        front = temp;
        rear  = temp;
        return;
    }
    
    // assign data of queue structure

    rear->next  = temp; // point rear pointer to next pointer = assign to temp
    rear = temp; // assign rear to temp keep front pointer at beginning fifo
}

void Queue::deQueue()
{

    // if queue is empty, return NULL
    if (front == NULL)
    {
        cout << "Queue is empty, sorry!";

        return;
    }
    
    Node*   temp = front;       // assign front 
    
    //problem here
    front = front->next;        // move front one node ahead
    
    if(front == NULL)
    {
     rear = NULL;
    }
     delete (temp);
    
    return;
    }
    
bool Queue::isEmpty() 
{
    //   cout << "functions";
    //   cout << endl;
    return (front == NULL && rear == NULL);
}

int main()
{
    Queue yay;
    yay.isEmpty();
    yay.deQueue();
    cout << endl;
    yay.enQueue(5);
    yay.enQueue(6);


    cout << "Queue Front : " << (yay.front)->data << endl;
    yay.deQueue();
    cout << "After deqQueue " << endl;
    cout << "Queue Front : " << (yay.front)->data << endl;
    yay.deQueue();
    cout << "Queue Front : " << (yay.front)->data << endl;
    yay.deQueue(); // <- Problem here
    yay.deQueue();
    cout << "completed" << endl;
}

我已將問題隔離到第 90 行

    //problem here
front = front->next;        // move front one node ahead

它導致 int main() 中的此代碼不列印

    yay.deQueue(); // <- Problem here
yay.deQueue();
cout << "completed" << endl;

我知道我在指標指示等方面很弱，所以如果可以請告訴我我沒有看到什么將不勝感激，我已經研究了一段時間并且沒有解決。

此鏈接通過在線 gdb 獲取代碼

https://onlinegdb.com/0B0KzcHMa

This is the output with line 
Queue is empty, sorry!
Queue Front : 5
After deQueue
Queue Front : 6

And the output with line 90 and 96 commented out //96 commented to avoid double free


Queue is empty, sorry!
Queue Front : 5
After deQueue
Queue Front : 5
Queue Front : 5
completed
Delete should be happening now...


Now I know, I know I should be better at this traversal of nodes business 
but, I am not seeing it and this may help me remember it in the future :X

I believe its a simple fix but, everything I try reaches the former output
rather than the later with intended data represented, I believe it is
nexting out into random memory making memory leak or memory pointing wherever
thus it never goes back to main to complete terminal messages

uj5u.com熱心網友回復：

問題在這里：

    Queue yay;
    yay.isEmpty();
    yay.deQueue();
    cout << endl;
    yay.enQueue(5);
    yay.enQueue(6);


    cout << "Queue Front : " << (yay.front)->data << endl;
    yay.deQueue();
    cout << "After deqQueue " << endl;
    cout << "Queue Front : " << (yay.front)->data << endl;
    yay.deQueue();
    cout << "Queue Front : " << (yay.front)->data << endl; // <<==== HERE

佇列插入了兩個元素，5 和 6。然后一個被彈出，然后另一個。這意味著yay.front現在nullptr按照您的deQueue邏輯閱讀串列的末尾。因此，讀取通過取消參考無效指標（在本例中為包含 的指標）來(yay.front)->data呼叫未定義的行為nullptr。

失去該取消參考（一種或另一種方式），代碼不應再出錯。

標籤：C 班级 指针 链表 队列

上一篇：如何在容器中運行.NETWebAPI？

下一篇：如何在多行上使用if條件？